add proxy_server & proxy_type to server install #641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastelfreak
reviewed
Jan 25, 2023
|
@sabo thanks for the PR! can you please add some unit tests for the change? |
|
great! we would like to use this feature |
Please update REFERENCE.md with $ bundle exec rake strings:generate:referenceAdd it to the PR and CI should continue. |
bastelfreak
force-pushed
the
bugfix/prometheus_server_install_proxy
branch
from
3ef4764
to
2b163f0
Compare
bastelfreak
force-pushed
the
bugfix/prometheus_server_install_proxy
branch
10 times, most recently
from
71ab83b
to
24f425f
Compare
bastelfreak
force-pushed
the
bugfix/prometheus_server_install_proxy
branch
from
24f425f
to
2bb782f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
Adds proxy parameters to the archive resource in install.pp, allowing prometheus to be installed from behind a proxy server.
This Pull Request (PR) fixes the following issues
PR #596 said it closed issue #186. However, while that PR adds
proxy_serverandproxy_typeto Alertmanager and every exporter, it did not add the proxy parameters to the installation of prometheus itself.